Fix spec where mysql_users was failing for SLES #1649
Merged
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix mistakes fix spec for the changed query
rahuls2997
force-pushed
the
CAT-2033
branch
from
e1a0a15
to
118f33b
Compare
rahuls2997
requested review from
alexjfisher,
bastelfreak and
a team
as code owners
bastelfreak
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the fix, we added a condition where while fetching list of users, we skip users where there is no hostname available.
Additional Context
The acceptance tests were failing for SLES platform. On further inspection, for SLES which was using MariaDB 10.11 version, there was a
PUBLICuser created by default with no hostname. The filter and mysql expression filters out such cases and fail the resource command.Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)